Trend & Compare: Period lengths + note if not equal

[gregallensworth]

Both Trend and Compare,

• add to the date readouts, the duration of the period e.g. "12 months"
• If the two durations are not equal, show a message "It's best to select two periods of the same duration and same months."

[gregallensworth]

Here we go:

Compare

Duration of each period is displayed. Messages are displayed if the durations are inequal OR if the durations are not the same months.

Note that the two sections are separately controlled halves of a two-column layout, so it would be non-trivial to create a double-width message spanning both halves and centered across the page.

[gregallensworth]

Here we go Trend

Again with a message describing either a mismatched duration or a mismatched start-month.

Here, placing one across the middle between the two charts seemed to make sense as well as being technically easy.

[gregallensworth]

Ready for review, see new gda-issue102-chartdatespans branch.

[danrademacher]

So just checked out, ran locally using npm start and getting this:

That's a totally new one to me, at least the giant RED screen formatting of error.

[gregallensworth]

This should be fixed as of commit 1466008

This corrects the handling of the date range stuff in two ways:

• It is now based on the Period A and period B sliders as provided from global state, instead of the provided slider values specific for the selected areas. That is to say, it will now work even if no comparison areas are selected and showing only reference data.
• It now expects conditions of no data .g. during startup, and works around them more carefully.

[gregallensworth]

Merged, and looking good.

[danrademacher]

Huh. Client response:

In the trend area, remove the mention “ it’s best to select two periods of the same duration” - The comment does not apply to trend in the compare area I like the reminders of months. Change the mention to “ Select two periods with same start month and duration.” Put in in lower case and small type Put number of months in smaller font as well

None of these seem hard, though also debatable.

Thoughts?

[gregallensworth]

• [x] Trend, remove/warning detection of periods having same duration (keep detection/warning of start month)

• [x] Compare, merge both messages into one message as worded above

• [x] Compare, warning message should get smaller font + all lowercase

• [x] Compare, "(X Months)" readout in smaller font

[gregallensworth]

• Trend, removed the duration note, but kept the one about same starting month.

• Compare, merged both messages into one as worded above. Adjusted font size for both the message, and the X Months readout.

[gregallensworth]

Already done and deployed two weeks ago. Closing.