GreenInfo-Network / nyc-crash-mapper-chart-view

Chart view for NYC Crash Mapper that allows for viewing Trends, Comparing, and Ranking of various NYC geographies
http://vis.crashmapper.org
MIT License
2 stars 1 forks source link

Crash Mapper issue 97 - Map and Chart cross-links #107

Closed gregallensworth closed 5 years ago

gregallensworth commented 5 years ago

https://github.com/GreenInfo-Network/nyc-crash-mapper/issues/97

The chart app and map app have totally different ideas of identifying polygonal areas: identifier for the Map (the unique name/ID, e.g. 23) and primary for the Chart (a unique but verbose string e.g. Bronx, NYPD Precinct 123) As a result, the Map links from Chart and the 3 Chart links from Map don't work as expected: they load the expected area type, but not the specific area and its data.

This PR will fix this, so the cross-links work properly.

gregallensworth commented 5 years ago

There are changes to both the Chart and Map apps here, and they should both be merged and deployed at the same time.

https://github.com/GreenInfo-Network/nyc-crash-mapper/pull/98 https://github.com/GreenInfo-Network/nyc-crash-mapper-chart-view/pull/107