Overall this is looking good! In future, it would be ideal if you could commit smaller changes and many more commits for a PR like this, so we can see how the changes build up, rather than a single 1400-line commit. But the result is working well and looking good, so that's great.
A few items to resolve here:
Fixes and minor changes
[x] Custom area not working. This tool allows a user to go to the map application and select a custom ara and have that populate:
[x] Make the distances between columns flex for fit on smaller laptop screens. Here's the vis on a 13" MacBook:
The site overall is not super responsive, but a bit less space between the bars and first pie would probably solve this, and ideally allow to flex so it can be wider on wide screens.
[x] Make the number next to the name larger Style it similar to PERIOD B (X)
This could use a bit of upgrade:
Keep the text colors, but let's make the font sizes and parens around number match to the PERIOD labels, which are more legible.
[x] Tooltip tweaks
Round the value to integer
Use human readable labels (Bus-Van and not Busvan)
[x] More space between each row
This is a bit tight:
[ ] Add title to legend: RESPONSIBLE VEHICLE
Make these smaller to fit in a title
Bigger changes
these are a bit bigger.
[x] Add citywide as default, disappears as soon as you select on area, so the page isn't blank on default load. This is to avoid a default view like this:
If citywide load time is too long, we could also consider adding a message like "Select a geography to view vehicle information." But a default citywide would be much better!
[x] Make the BAR heights between Period A and Period B be proportional based on the max of the two periods. Keep the yellow frame, half full when half as much, etc.
so in this case the bar max would be set by 969 on the left:
Overall this is looking good! In future, it would be ideal if you could commit smaller changes and many more commits for a PR like this, so we can see how the changes build up, rather than a single 1400-line commit. But the result is working well and looking good, so that's great.
A few items to resolve here:
Fixes and minor changes
We consume that area from URL params here https://github.com/GreenInfo-Network/nyc-crash-mapper-chart-view/blob/master/src/common/sqlQueries.js#L220-L227, and it works int eh other views. I am not sure yet why it is not working with your new Vehicle detail query, since I think it should just append as another
WHEREclause. Can you take a look? Maybe there's aGROUP BYdependency we need to resolve.The site overall is not super responsive, but a bit less space between the bars and first pie would probably solve this, and ideally allow to flex so it can be wider on wide screens.
Keep the text colors, but let's make the font sizes and parens around number match to the PERIOD labels, which are more legible.
[x] Tooltip tweaks
Use human readable labels (Bus-Van and not Busvan)
[x] More space between each row This is a bit tight:
[ ] Add title to legend: RESPONSIBLE VEHICLE Make these smaller to fit in a title
Bigger changes
these are a bit bigger.
If citywide load time is too long, we could also consider adding a message like "Select a geography to view vehicle information." But a default citywide would be much better!
so in this case the bar max would be set by 969 on the left: