GreenInfo-Network / nyc-crash-mapper-chart-view

Chart view for NYC Crash Mapper that allows for viewing Trends, Comparing, and Ranking of various NYC geographies
http://vis.crashmapper.org
MIT License
2 stars 1 forks source link

Implement Dynamic Legend #28

Closed clhenrick closed 6 years ago

clhenrick commented 7 years ago

The legend should change based on whether the user has selected "trend" or "compare".

screen shot 2017-10-17 at 1 56 43 pm

Circles for "compare" should be displayed while lines for "trend" should be displayed.

To Consider:

danrademacher commented 7 years ago

Good question re legend items and filter.

My first thought is that this legend is short enough and clear enough that it's better to leave it static rather than filtering legend items based on applied filters. Having them all there makes the "system" immediately evident, even if someone sends you a link that's filtered.

Though in that case we need to be sure it's clear filters are active so you don't misread the chart as "no fatalities" if the fatalities are merely filtered out.

clhenrick commented 7 years ago

@danrademacher perhaps it then makes sense to remove the "deselect" option from the Trend View? Seems inconsistent to make the Legend interactive in one view but not the other.

danrademacher commented 7 years ago

Or maybe instead of element disappearing, it just grays out or otherwise shows as deselected?

clhenrick commented 7 years ago

Not sure I'm following.