GreenInfo-Network / nyc-crash-mapper-chart-view

Chart view for NYC Crash Mapper that allows for viewing Trends, Comparing, and Ranking of various NYC geographies
http://vis.crashmapper.org
MIT License
2 stars 1 forks source link

Add "citywide" to Compare #58

Closed danrademacher closed 6 years ago

danrademacher commented 6 years ago

I suspect this will immediately become an enhancement... but for now it's a question.

From Christine:

In compare, the filter by boundary should include “citywide” as an option

I can see that this makes sense just in context of Compare. One geog and two periods, which implies nothing under "Select Areas".

And pretty sure we'd have to special case it so the option is available only in Compare.

Is there a simpler solution I might be missing?

clhenrick commented 6 years ago

Another way this could be addressed would be to have "citywide" be the default option if no crash filters are selected. Would that be acceptable? Or be too confusing to the user?

danrademacher commented 6 years ago

Hmm, interesting thought.

But that seems confusing to me -- so if no crash type are selected, we would show all crash types for the whole city? It's possible to have one or more Geographies selected and no crash types.

Not a common use case, but could happen as a user is playing around with the UI and would be unexpected to have, say, two Community Boards selected and as you progressively turn off crash types, you get fewer and fewer crashes until the last one, when suddenly you have every crash in the whole city.

clhenrick commented 6 years ago

Nevermind, that doesn't make any sense, I misread the request.

Yeah I think the only option is to have a special case for Citywide in Compare. But then what happens when you have Citywide selected and switch to a different chart view? Seems like a confusing UX.

A single Borough renders a whole lot of dots in Compare, but Citywide would render them for every borough. Is this even a good idea?

danrademacher commented 6 years ago

New goal:

image

gregallensworth commented 6 years ago

Working. Screenshot:

image

danrademacher commented 6 years ago

Looked just right so I merged and deployed. For the record, I tested locally turning on circles for Citywide and as expected it nearly crashed my browser. Very slow. Noting here in case anyone later wants to add circles for citywide.