GreenInfo-Network / nyc-crash-mapper-chart-view

Chart view for NYC Crash Mapper that allows for viewing Trends, Comparing, and Ranking of various NYC geographies
http://vis.crashmapper.org
MIT License
2 stars 1 forks source link

Charting for custom geographic areas #64

Closed gregallensworth closed 6 years ago

gregallensworth commented 6 years ago

https://github.com/GreenInfo-Network/nyc-crash-mapper-chart-view/issues/62

Followup to https://github.com/GreenInfo-Network/nyc-crash-mapper/pull/72 This adds to the Trend and Compare charting, support for custom-drawn geographies.

danrademacher commented 6 years ago

Hmm, when I run this locally and draw area, see charts for area, clear area, then click Draw Area again, the map loads but the data never does, with this in the console:

(index):1 POST https://chekpeds.carto.com/api/v1/map?stat_tag=API 400 (Bad Request)
index.js:178 Uncaught ["missing FROM-clause entry for table "a""]

I wonder if it involves unexpected or malformed URL params coming back to the map?

Here's the link I have:

http://localhost:8080/#/?cfat=false&cinj=true&clearCustomGeography&customGeography&endDate=2017-12&geo=custom&identifier=3&mfat=false&minj=true&pfat=false&pinj=true&setReferenceEntity=function%20%28%29%20%7B%0A%20%20%20%20return%20dispatch%28actionCreator.apply%28undefined%2C%20arguments%29%29%3B%0A%20%20%7D&startDate=2016-12

Seems like some of the stuff around setReferenceEntity are somehow broken. I suspect some of these params just shouldn't be present for the map.