GreenInfo-Network / nyc-crash-mapper-chart-view

Chart view for NYC Crash Mapper that allows for viewing Trends, Comparing, and Ranking of various NYC geographies
http://vis.crashmapper.org
MIT License
2 stars 1 forks source link

color specs for nav elements from client #75

Closed danrademacher closed 6 years ago

danrademacher commented 6 years ago

Speaking of detailed feedback... Christine says we still don't have consistent colors from Map to Chart views. I swear I had relented changed these back in the fall. Need to re- re-confirm.

For trend compare rank tabs: Title and top navigation fonts : 92,165,171 Background top nav and right nav: 110,110,110 Selections yellow tabs - not selected: 255,249,215 selected: 253, 203, 104 Yellow tabs fonts : 20,132,142

For about tab words with links : 92,165,171

Not at all about intersections, obv, but probably not hard to review and make 'em whatever colors she wants

gregallensworth commented 6 years ago

I went through and compared the color codes used in the top nav and yellow buttons, and confirmed that on the live CrashMapper and CrashMapper Chart pages, the color codes are identical. As such, we do already have "consistent colors from Map to Chart views"

I have made the color changes nonetheless on the Chart View, and screenshots are below. Many changes are quite subtle, with the background fill and About links being the most visually obvious. In the case of the top nav and the yellow buttons, the new color codes are somewhat lighter, and may decrease readability to some folks' eyes.

After changes

after

Before changes (From Live Site)

before

gregallensworth commented 6 years ago

Per chat: The color codes between CrashMapper and CrashMapper Charts are already the same, and the new color codes are different than those currently in use on both sites. That's OK if she wants to change it in both sites, but let's bounce it back to the client to see if this is what she had in mind.

danrademacher commented 6 years ago

I finally understand what she's talking about. Sidebar vs sidebar on the live site (which doesn't have this change yet), and the chart sidebar is much lighter.

Here's a comparison with an easy fix. Left live vis is clearly lighter than right live map. Middle is closer to map. image

So her concern should be addressed if we leave all else the same as in live site but change .grid-right to

.grid-right {
    background-color: rgba(0,0,0,.6);
}