This branch gda-58-comparecitywide expands on the gda-96-comparesums branch and PR 97., to fulfill issue #58 so the Compare section has a persistent Citywide readout. Reviewing and merging PR96 and issue 96 first, may reduce the amount of code being reviewed here.
DotGridChart component, reworked the render() method into two sections. The chart-dots section will be nulled if props.drawdots is false. This prop would be set in DotGridWrapper in the case of entityType == citywide.
This new chart section was added into DotGridChartsContainer
App.jsx now, on componentDidMount(), does a pull for citywide entity data (in addition to any selected comparison type), as we will be wanting citywide data in both Compare and Trend views even on initial page load.
This branch
gda-58-comparecitywide
expands on thegda-96-comparesums
branch and PR 97., to fulfill issue #58 so the Compare section has a persistent Citywide readout. Reviewing and merging PR96 and issue 96 first, may reduce the amount of code being reviewed here.render()
method into two sections. The chart-dots section will be nulled ifprops.drawdots
is false. This prop would be set inDotGridWrapper
in the case ofentityType == citywide
.DotGridChartsContainer
componentDidMount()
, does a pull for citywide entity data (in addition to any selected comparison type), as we will be wanting citywide data in both Compare and Trend views even on initial page load.