GreenInfo-Network / nyc-crash-mapper-chart-view

Chart view for NYC Crash Mapper that allows for viewing Trends, Comparing, and Ranking of various NYC geographies
http://vis.crashmapper.org
MIT License
2 stars 1 forks source link

Client request for Compare layout changes #99

Closed danrademacher closed 6 years ago

danrademacher commented 6 years ago

Hmm, my attempt at minimal intervention Compare changes didn't fly entirely.

Revised proposed layout: image

Change list

gregallensworth commented 6 years ago

Here we go:

image

Layout is as depicted above, except that per discussion: the killed & injured sums were shuffled a bit.

Still to do: determine feasibility of comparing the two periods to create percentage diffs.

gregallensworth commented 6 years ago

Here are the percentage change readouts.

Standard percentage change of A relative to B as a baseline

Could display this on both; right now it is calculated but suppressed in Period B. Here for example, Period B's 3 fatalities versus 2 fatalities would be a "+50% change" relative to Period A. This would allow either one to be "the baseline" but also presumes that folks remember how reciprocal fractions work.

diffpercents

If a diff is under 1% then a special message is displayed.

under1percent

If the numbers are the same, NO CHANGE is displayed

nochange
danrademacher commented 6 years ago

Just deployed to live site

danrademacher commented 6 years ago

Client found an issue with Custom Area -- looks like when a Custom Area is drawn, its stats overwrite the Citywide: image

Citywide says 129 injured Link

And same with Custom Area cleared: image

Citywide 63,418 injured Link

gregallensworth commented 6 years ago

Here we go. I added a patch into the DotGridSums to force citywide for the Citywide section even if it is not our reference entity.

image

gregallensworth commented 6 years ago

Closure of this Issue was accidental. Need to deploy and confirm on live site, before closing this.

danrademacher commented 6 years ago

Confirmed and deployed: image