GreenInfo-Network / nyc-crash-mapper

React Redux web application for viewing, filtering, & comparing trends of automobile collision data published by the NYPD.
http://www.crashmapper.org
MIT License
16 stars 4 forks source link

Make intersection circle legend #82

Closed danrademacher closed 6 years ago

danrademacher commented 6 years ago

Client asked to add it to crash types:

On map in legend can you add the intersection symbol under none

But I think that would be weird, esp since it only makes sense when intersections are enabled.

How about something next to the button only when active, like this: image

That's a span like this

    width: 15px;
    height: 15px;
    background-color: #17838f;
    display: inline-block;
    margin-left: 5px;
    margin-right: 5px;
    vertical-align: middle;
    border-radius: 50%;
    border: 1px solid white;
    opacity: 0.7;

Main downside here is it will push the intersection name even further over. Hmm.

danrademacher commented 6 years ago

I think this idea has legs, though not sure how much impact it will have on the geography name. And whether we should have blue squares next to the other items, to server as legends there as well.

what do you think?

gregallensworth commented 6 years ago

I think that adding a legend item will push the area names over by 2-3 characters, and the space is already barely sufficient for some area names and insufficient for others. "GRAND ST & U..." would become "GRAND ST ..." and "METROPOLITAN" would become "METROPOLIT"

I also don't think it would communicate much.

danrademacher commented 6 years ago

That is a much better solution.

so this by default:

Choose a boundary type, then click an area on the map to filter crashes within that area.

image

and if Intersections is selected, then:

The 500 most dangerous intersections over last 2 years. Zoom to see 90-foot radius for each.

image

Match text styling to the "Start Year" and "End Year" labels on the filter by date element

gregallensworth commented 6 years ago

This is now in place. I also added a custom message for Custom shape, since "click an area on the map" isn't accurate there.

2018-01-30 17_02_29-start 2018-01-30 17_02_40-start 2018-01-30 17_02_52-start