Error in console, line 111

GreenInfo-Network / nyc-crash-mapper

React Redux web application for viewing, filtering, & comparing trends of automobile collision data published by the NYPD.

http://www.crashmapper.org

MIT License

16 stars 4 forks source link

Closed gregallensworth closed 6 years ago

gregallensworth commented 6 years ago

I'm seeing an error in the JavaScript console. App is working, but still go check this out.

Error: Uncaught TypeError: Cannot read property 'length' of undefined LeafletMap/index.js line 111

LeafletMap/index.js
line 111
if (geojson.features.length) {

gregallensworth commented 6 years ago

Solved.

Line 111 was checking geojson.features.length but not checking that geojson.features itself was defined. Easy fix.
Line 61 was fetching GeoSON if a geo was given but no identifier This was leading to a GeoJSON query to CARTO, for a type=undefined geometry type, which of course was failing. I reworked this to only do this if geo is not "citywide"