GreenInfo-Network / seattle-building-dashboard

Energy benchmarking for Seattle
https://greeninfo-network.github.io/seattle-building-dashboard/
ISC License
1 stars 0 forks source link

Scope out main map changes #11

Closed danrademacher closed 2 years ago

danrademacher commented 2 years ago

It looks like we make these changes in the config file.

Order of map layers on the home page look like they can be changed here: https://github.com/GreenInfo-Network/seattle-building-dashboard/blob/master/src/cities/seattle.json#L86-L215

Popup here: https://github.com/GreenInfo-Network/seattle-building-dashboard/blob/master/src/cities/seattle.json#L66-L84

┆Issue is synchronized with this Asana task

danrademacher commented 2 years ago

For the weather normalized change:

Good question on the _wn change. If it’s relatively straightforward to switch to two main parts of the map that would be best. If not, let me know and we can discuss.

image

danrademacher commented 2 years ago

Hold on this till everything else is done

tomay commented 2 years ago

Question on this comment:

Add one GHG metric to popup for selected building

Seems like we'd want that for the selected year, and then that would go into this section? image

So that's not a seattle.json change per se, instead seems this is a new measure that would need to be integrated into the template, the number needs to be colored according to its rank, etc.

~Is there a section that corresponds to this on the left sidebar? If this corresponds to the cards on the report, then the field is total_ghg_emissions_intensity~ I see this now, "Seattle GHG Intensity" uses total_ghg_emissions_intensity

danrademacher commented 2 years ago

@seattle-benchmarking since we have some time today, should we go ahead with these main map changes?

That would look like:

  1. Move the GHG section in left bar to the top and make "Total Seattle GHG Emissions" the default layer image
  2. Change the use of weather-normalized as described in this comment, https://github.com/GreenInfo-Network/seattle-building-dashboard/issues/11#issuecomment-989208592

About @tomay's last comment above about a new GHG measure in the popup, I think we're best off leaving that as wont-fix for this phase since it would require reworking the template and likely a taller popup that might cause other issues.

tomay commented 2 years ago

Looks like there are several places in seattle.json where we could update measures to use "weather normalized" EUI:

Popup

Map Layers/Sidebar

seattle-benchmarking commented 2 years ago

sorry just saw this. @danrademacher I agree that adding the new GHG measure to the popup can wait until next year.

if you end up making changes to the sidebar, the following make sense to me:

  1. Move the GHG section in left bar to the top and make "Total Seattle GHG Emissions" the default layer per @danrademacher comment
  2. Change to site_eui_wn for the (1) popup, (2) sidebar quartiles and sidebar EUI
  3. Suppress/hide Source EUI and Site Total Energy Use layers
  4. Order sidebar buckets in reverse of current (Greenhouse Gas Emissions, Energy Perf Metrics, Property Info)
danrademacher commented 2 years ago

@tomay this branch has the changes that achieve layer ordering and default layer, but not the wn changes

https://github.com/GreenInfo-Network/seattle-building-dashboard/commit/f62778378ef222d02e73756a8b7eca9c8fdcfe51

tomay commented 2 years ago

I believe this is done, please reopen if there is anything more to do

seattle-benchmarking commented 2 years ago

@danrademacher @tomay Could you replace the Site Total Energy Use layer with the Site EUI one?

danrademacher commented 2 years ago

Deployed to GH pages: image

This can be updated in the production code simply by replacing this file: cities/seattle.json

With the file at https://raw.githubusercontent.com/GreenInfo-Network/seattle-building-dashboard/master/src/cities/seattle.json