Buildings with missing TYPE

danrademacher commented 2 years ago

Confirmed with Terry that all buildings should have a TYPE, but in the past maybe he backfilled where that was missing from the city's data. It is causing errors in calculations that compare a building to similar buildings.

Terry will populate.

There are 515 records like that. Since empty strings are not null in Postgres, I used this query to find those:

SELECT count(*) FROM public.seattle_buildings_master_copy_for_update2020 where length(property_type)=0

Those records are just 107 buildings across multiple years:

SELECT count(distinct(id)) FROM public.seattle_buildings_master_copy_for_update2020 where length(property_type)=0

And those buildings are:

cc @@seattle-benchmarking

┆Issue is synchronized with this Asana task

seattle-benchmarking commented 2 years ago

buildings with N/A in type won't display the report at all. use this id to test fix

danrademacher commented 2 years ago

Terry, can you clarify the note about 24888? Our understanding is that you will be populating these property_type fields and we can assume it won't be null.

Right now, 24888 is now a Senior Center Community, so it mostly works. But this one still fails with the NA: https://greeninfo-network.github.io/seattle-building-dashboard/#seattle/2020?layer=energy_star_score&sort=energy_star_score&order=desc&lat=47.61779&lng=-122.33233&zoom=14&building=21471

There are still 22 buildings with no property_type with this query in CARTO:

SELECT distinct(id) FROM public.seattle_buildings_master_copy_for_update2020 where length(property_type)=0

But for 24888 and other previously null buildings, we're also seeing missing data for the Building Type EUI_wn, which is causing the infinity symbol in this screenshot:

It looks like there are 147 buildings that have some value for property_type but nothing for building_type_eui_wn. That's in this query:

SELECT count(distinct(id)) FROM public.seattle_buildings_master_copy_for_update2020 where length(property_type)>0 and building_type_eui_wn is null

seattle-benchmarking commented 2 years ago

@danrademacher sorry that note above (on id = 24888) was a note to myself. I was working through these today but hadn't finished. There are multiple different data issues causing problems with this. I'll follow up tonight once I finish cleaning up what I can.

seattle-benchmarking commented 2 years ago

@danrademacher I fixed the data issues for building_type_eui_wn for Senior Center Community That fixed the infinity sign issue But not seeing the Energy Use Compared to Average chart for a few Senior Center Community buildings id = 21741

seattle-benchmarking commented 2 years ago

okay i figured that out but it's related to something else. will close this out and open a different issue

GreenInfo-Network / seattle-building-dashboard

Buildings with missing TYPE #19