GreenPassApp / greenpass-app

https://greenpassapp.eu
GNU General Public License v3.0
97 stars 7 forks source link

Validation rules out of date #45

Open a-leithner opened 2 years ago

a-leithner commented 2 years ago

Using the current version of the app, 1.2.2, I have noticed that the (Austrian/Viennese) rules for validating all certificates are well out of date.

Examples:

Yet, these certificates still are being reported as "valid" by the app. This is not desirable, obviously.

I have noticed that the current version is from December 23rd last year and I thus believe that the rules are hard-coded in the app? If this is the case, is there any intent to speed up the release cycle? (Rules tend to change quite rapidly in Austria...)

I have used the Swiss Validation App for a long time and thus suggest an alternative scheme of keeping the rulesets up to date: How about fetching them from an online source (like, once every 7 days)? Also, the Austrian Ministry of Health publishes the rulesets as CBOR files, as specified here: https://github.com/Federal-Ministry-of-Health-AT/green-pass-overview#details-on-trust-listsbusiness-rulesvalue-sets

Aside from privacy concerns (of which there shouldn't be that many because only the CBOR files would be downloaded), wouldn't that be a very simple fix for the stale rule data problem?

(Please note that I installed the APK directly from the website and as I do not have access to Google Play, I cannot verify whether this behaviour is specific to the APK version; it would be bad enough, however.)