search

GreenScheduler / cats

CATS: the Climate-Aware Task Scheduler :cat2: :tiger2: :leopard:
https://greenscheduler.github.io/cats/
MIT License
47 stars 7 forks source link

fix off by one #100

Closed abhidg closed 3 weeks ago

abhidg commented 1 month ago

This fixes off-by-one errors in the code which led to #99. Detailed info is in commit messages.

andreww commented 1 month ago

This all looks good to me but I think it would be good to turn the error in #99 into a test case - do we actually need a handful of integration tests where we feed in chosen forcasts and test the whole code?

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.21%. Comparing base (ad68095) to head (92d7608).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #100 +/- ## ========================================== + Coverage 89.19% 89.21% +0.01% ========================================== Files 14 14 Lines 546 547 +1 ========================================== + Hits 487 488 +1 Misses 59 59 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.