Fix test failures on main

GreenScheduler / cats

CATS: the Climate-Aware Task Scheduler :cat2: :tiger2: :leopard:

https://greenscheduler.github.io/cats/

MIT License

47 stars 7 forks source link

Fix test failures on main #82

Closed andreww closed 2 months ago

andreww commented 2 months ago

This fixes two (of the three) failing tests on main.

The issues that are fixed involves a test case where newlines are printed by cats, which are not in the reference output in the tests (an easy fix).

andreww commented 2 months ago

I think some of my "fixes" in here are properly addressed in #80, 058a780 in particular. @tlestang - we should probably figure out how to order these two PRs, or if it's best to chop this one up / just take the stuff that's not involved in #80.

tlestang commented 2 months ago

Hi @andreww - I split the rewriting/testing of the carbon footprint estimation module into two PR #79 and #80. I just merged #80 in which fixed the failing test on main. I also resolved a few inconsistencies (unused function or variable like jobinfo) that were necessary to introduce in order to integrate the changes in two distinct steps without breaking cats.

tlestang commented 2 months ago

About the conflicts:

The check_clean_arguments.py was removed, because the job of processing and validating command line arguments is now carried out in the config module.
After #80 the in-memory representation of the configuration file (config dictionary) doesn't have to leave the config module, so the config.get_runtime_config function doesn't have to return it in __init__.py. Same goes for _jobinfo.

andreww commented 2 months ago

Thanks - I'll reorder and rebase this branch so that it makes sense now #80 is merged.

andreww commented 2 months ago

Rebased and cleaned all of this up. Two new PRs inbound. We can kill this one.