Admin edit prizes - Githubissues

GreenStepsChatt / greensteps

This is the web app for Green Steps, a community focused initiative that incentivizes litter cleanup in the Chattanooga area.

https://www.greenstepschatt.com/

MIT License

12 stars 31 forks source link

Admin edit prizes #148

Closed jdg006 closed 6 years ago

jdg006 commented 6 years ago

Description

Admins can now edit prizes from the admin dashboard by clicking the edit button next to the title of the prize.

Fixes #140

Developer Checklist

You can mark items off by replacing [ ] with [x] or in the rendered markdown, you can simply check the checkbox.

[x] I have read and followed the contribution guidelines.
[x] All specs and linters pass (including Code Climate)
[x] I have followed the style of nearby code
[x] The build on Semaphore is successful
[x] I have added tests for my changes.
[x] I have gone through my changes by hand, either in the browser or terminal, which ever makes sense
[x] I have internationalized my changes

jdg006 commented 6 years ago

The spec that is not passing on semaphoreci passes locally. Let me know what I need to do here to get it passing and I'll get right to it.

jdg006 commented 6 years ago

I had to change some of the paths I was using because I noticed that the paths had been changed on the master branch's config file. I think they are all good now though. Let me know what you think and if you want me to change anything.

crawfoal commented 6 years ago

Also, don't worry about flaky test that are unrelated to what you're working on. I fixed those in the PR I'm working on, so once I get that finished and merged in, you could pull those changes into your branch if the flaky tests are causing issues for you.

crawfoal commented 6 years ago

Also, can you add some basic styling? A couple things that stood out to me were (1) it would be good to apply the prize form styles to edit form too (2) maybe play around with the position of the edit button - would it look better if it was right aligned and had a little left padding?

jdg006 commented 6 years ago

I think I have corrected everything. Let me know if I need to add anything or if I need to make further corrections.

crawfoal commented 6 years ago

@jdg006 Thank you for your work on this!