GreenWaves-Technologies / gap8_openocd

gap8 openocd port
GNU General Public License v2.0
3 stars 1 forks source link

Semihosting incorrectly handled in gap8_poll #4

Open radrogow opened 2 years ago

radrogow commented 2 years ago

Code is incorrectly notifying about target halt, when the processor might've been resumed by following line: https://github.com/GreenWaves-Technologies/gap8_openocd/blob/b2555786cf86a699a230c586c6cd71976cba7a08/src/target/gap8/gap8_semihosting.c#L156

That leaves connected GDB thinking that the processor is stopped, while the processor is running.

Please compare code for GAP:

https://github.com/GreenWaves-Technologies/gap8_openocd/blob/b84d97ec4d2e601e704b54351e954b1c58d41683/src/target/gap8/gap8.c#L517-L533

And the same code for ARM:

https://github.com/GreenWaves-Technologies/gap8_openocd/blob/fba438fde7355bcbe5fb4dc0ce712665d3d8a6da/src/target/arm7_9_common.c#L824-L837

Code for arm doesn't call target_call_event_callbacks if the operation was handled by the semihosting, same should be happening for gap.