search

GreenXenith / minetest-tools

Minetest extension for Visual Studio Code
MIT License
28 stars 6 forks source link

Switch to TypeScript #30

Closed AFCMS closed 1 year ago

AFCMS commented 1 year ago

Fix #19

Follow the VSCode official way of creating a typescript extension without webpack.

Since the .vscode folder isn't added to git, local files will need some updates to be able to run the extension (I guess).

Maybe it would be better to commit tasks.json and launch.json?

GreenXenith commented 1 year ago

Looks fine, and seems to work as intended. However, I would like to keep 4-space indentation. If there is a way to automatically format indentation, that would be fine.

Including tasks/launch configuration if important for development is also a good idea as long as it does not interfere with regular user experience.

AFCMS commented 1 year ago

@GreenXenith Bump. Could I get a review? I am stuck for the other parts of the refactoring because of that pr. No presure ofc.