Make sure your code works and is tested before creating a PR
Pull Requests will contain all of the information included on the PR ticket template. DO NOT APPROVE the PR if your teammate has not completed this
Do NOT work someone else’s ticket unless you are pairing or working together
Do NOT rewrite someone else’s code
Do NOT work ahead of your teammates. It is better to help them so that everyone stays together than to “leave anyone behind”
Do NOT add scope to a ticket that you have be assigned without team approval
Have conversations and chat with your teammates to get to know them better
Trust your teammates. You all belong here and can produce good code!
DO NOT and I repeat DO NOT move on to another milestone if there are still tickets in your current milestone. Work TOGETHER as a team to get all tickets in the milestone completed, reviewed, and merged.
Don’t be an asshole! Because they stink...
Follow the PR Review Process:
Reference the issue you are resolving on the PR
Removed all console logs and commented out code
Assign team members to review
Once it has been approved by 2 teammates, the person who created the PR merges it in.
By approving a teammates Pull Request, you are saying that you did the following:
Fetched the teammates' branch to run locally on your machine
Tested the code locally based on the PR instructions
Looked at the code and ask questions using GH Review
Approve the PR
NOTE:
Once code is merged to main, it is now the source of truth.
Each team member will need to merge main into their own branches to continue to work, so you will want to make sure that your code works with the new changes.
Requirements during development
Follow the PR Review Process:
By approving a teammates Pull Request, you are saying that you did the following:
NOTE: Once code is merged to main, it is now the source of truth.
Each team member will need to merge main into their own branches to continue to work, so you will want to make sure that your code works with the new changes.