Greengroove / GG-LootFilter

Loot filter for Path of Exile
https://www.pathofexile.com/forum/view-thread/1566921
37 stars 19 forks source link

Can't turn off the dropsound from Reinforced Steel Net's #14

Closed TerohsLab closed 6 years ago

TerohsLab commented 6 years ago

I edited the corresponding parts of the filter as shown below. It hides the nets, but i can't turn the drop sound off.

I assume thats a ggg bug?

Also see here : https://www.reddit.com/r/pathofexile/comments/821d42/neversinks_itemfilter_version_561_hotfix_for_t16/

Hide  # ~Misc - Challenge leagues - Bestiary items - Reinforced Steel Net |Disable
    Class "Stackable Currency"
    BaseType "Reinforced Steel Net"
    SetFontSize 45
#   PlayAlertSound 2 0 # A - Tier 4

Hide  # ~Misc - Challenge leagues - Bestiary items - Any Net |Disable
    Class "Stackable Currency"
    BaseType Net
    SetFontSize 45
#   PlayAlertSound 2 0 # D - Leveling items 
Greengroove commented 6 years ago
TerohsLab commented 6 years ago

I used Filterblast to edit the filter. Here is my preset : http://filterblast.oversoul.xyz/Greengroove/3392hs3

I kinda feel like the "Disable Any Net" switch under Misc -> Challenge Items -> Bestiary Items isn't working as it should be, since all lower nets are still visible until you also Hide "Generic Currency (catch all)" under Endgame -> Currency.

Greengroove commented 6 years ago

I am aware of that. I think it's fine. It's like an extra safety line. And you'll want to disable the generic one anyway later on. Maybe I'll reconsider and set them to hide. The good part about the disable function is that it's good for performance. The more stuff is disabled the lighter it gets.

Do you think this should be changed?

TerohsLab commented 6 years ago

Its just very unintuitive for people who don't go into great detail to customize their filter. If someone just uses the endgame filter, but wants to hide the nets, its not going to work.

So i would personally change it yes.

Also is performance really that big of an issue? I assume thats why you also show the white/blue with super small font and low occupancy. Thats kind of annoying when you press ALT after killing bosses for example to pick up some chromatics since you still have space in your inventory. And then you missclick and end up with a bunch of white items in your inventory instead :D

Greengroove commented 6 years ago

Thanks for input, ill change nets.

Performance should be great overall. And I'm still unsure if there's anything to the issue. Some people told me, a not optimized filter is "slower" or can be. I have not seen any differences myself. Maybe on potato computers.

The problem with hidden items is that they must be shown in some way. By having them barely (but still) visible, you get to see the "better" hidden items easier, as compared to one big mess on the screen. Also I suspect that smaller (harder to click on) items may help when there's reeeeealy a lot of items on the ground (MF). If you remember, the labels may get misplaced if there's too many items on the ground. Small labels may help with this slightly. Previously I didn't minimize the items. But I tried a few variations before settling.

So I think this way more things will fit on screen and since you don't want these items transparency is in place. If you have an idea for this lmk. Am open to ideas.