search

Greengroove / GG-LootFilter

Loot filter for Path of Exile
https://www.pathofexile.com/forum/view-thread/1566921
37 stars 19 forks source link

FILTRATION IS CURRENTLY NOT SUPPORTED. DON'T USE IT TO CUSTOMIZE THIS FILTER! #4

Open Greengroove opened 7 years ago

Greengroove commented 7 years ago

The filter is fully compatible with Filterblast. FILTRATION IS NO LONGER SUPPORTED. DON'T USE IT TO CUSTOMIZE THIS FILTER! If you do the filter may not work properly.

The filter now uses some new advanced syntax that Filtration currently doesn't support. Adding this allowed me to implement many things that were previously not doable. Unfortunately that means that until Filtration gets updated smart blocks should not be used. Furthermore Filtration does not recognize some of the advanced syntax. That part of the filter will be removed after parsing (saving) with Filtration.

Currently you can only use Filtration to apply color themes. But beware that after applying a theme you won't be able to customize the code any further with Filterblast.

Let's hope Ben will update Filtration soon. Until then please use Filterblast.

azakhi commented 6 years ago

Is this still the situation? If so what are the problems?

Greengroove commented 6 years ago

Yes, It's still an issue and it will most likely remain an issue.

It's because Filterblast introduced a syntax that enables me to disable filter blocks instead of just hiding them. To my knowledge only Filterblast fully supports this feature. My filter uses this powerful feature very heavily. It helps with performance (a lot), but also has other functions. Once the feature is used to the extent as I use it, the filter also starts to behave differently. So it can be crucial that some blocks are disabled, while others are hidden. That is all written in the code (no concern to the user) and only Filterblast is able to tell how a block must behave.

As I said this feature is too good to give it up. It literally took my filter to the next level.

I know other filter makers use it as well and I know Neversink uses it too, but in a different way. I can't say for others, but my filter can break if you use anything other than Filterblast to customize my filter. And honestly once you get used to Filterblast, there really is no need for other tools.

But anyways, that is the basic problem. But there's other awesome advanced functions that Filterblast supports. So when I saw no updates coming from Filtration, I decided to fully embrace Filterblst. The creator is very responsive, talented and friendly, so I am really happy with the direction this project took.

azakhi commented 6 years ago

Okay however you like. I was just wondering what we can do to give full support but as it seems you prefer filterblast to be used for your filters even if we do.

Greengroove commented 6 years ago

Well I love Filtration. I would totally use it, if it supported all the features of my filter. But implementing such features might mean a lot of work and honestly I don't think that's warranted. Especially since everything can be done on Filterblast. There's also some other advanced options that Filtration doesn't support.

I think if Filtration was to be made compatible it should support most of the syntax listed here: http://filterblast.oversoul.xyz/help.html

But again, Filtration is freeware so...

azakhi commented 6 years ago

I see. A full syntax support is not what we want to implement either. My concern was that a user should be able to open any valid item filter and edit it without worrying if it will break the filter in game. I asked because of this part:

Currently you can only use Filtration to apply color themes.

We have some updates to be released and to my knowledge, you will be able to edit filterblade filters in Filtration and it should not cause any problems in game (Even existing filterblade syntax should not change as long as you know what you are doing). So I wanted to be sure before the release and solve issues if there is any.

Greengroove commented 6 years ago

Neversink uses a different syntax than Filterblast. So there's that. And most people use NS filter. But yes, if Filtration was to support the disable / comment instead of hiding, then editing with Filtration would not break my filter.

The color theme thing is also just related to the fact that Filtration can't parse my filter properly. The color themes are still compatible. So if the parsing (above issue) is fixed, the color themes should also work.