Closed metonym closed 1 year ago
Thank you so much for the rapid fix! 💚
I'll test this with Node 16, 18 and 19, and then we can likely have a new npm release out soon.
Until this is done, I'd recommend you and others to use Node 18 if possible, which seems to work fine.
Nice work! Thanks again for the quick fix :smile: This works well for all environments. with node 16, 18 and 19.
I'm merging this, but will fix the other tasks in separate PRs before making a new release since something has changed with how the styling is loaded in the latest versions.
If you want to use the new version directly, feel free to swap the npm install with linking to the GitHub repository and a specific commit: https://stackoverflow.com/a/17509764/4183985
Thank you for addressing this so quickly.
For sure, whenever there's an opportunity!
Welcome to help make further improvements if you have more ideas! 😄
Fixes #34
This is a hotfix that allows
pagecrypt
usage with Node 19.For some reason, the window/globalThis check is evaluated differently in Node 19.
Setting
globalThis
beforewindow
avoids the reference error thrown by Node when the branch is evaluated.I've tested this in Node 19 and Node 16.