search

Greenka236 / Tea_cozy

0 stars 0 forks source link

Semantic HTML #4

Open martoio opened 6 years ago

martoio commented 6 years ago

Your code is pretty good! One thing I would advise is to use more of the semantic elements, instead of relying on divs everywhere. 

div representing an image with a caption? Why not use the figure element for that? 

div to show a section of a site? section is made just for that.

Here's some links that explain why you use it and some of the elements available: https://www.w3schools.com/html/html5_semantic_elements.asp http://www.hongkiat.com/blog/html-5-semantics/ https://www.thoughtco.com/why-use-semantic-html-3468271 https://stackoverflow.com/questions/17272019/why-to-use-html5-semantic-tag-instead-of-div https://github.com/Greenka236/Tea_cozy/blob/2124fce2281fa4b900aaa022ac30996e6630ee4d/index.html#L82-L85

Greenka236 commented 6 years ago

Also done, thank you for all of the resources, they were very useful. I think I removed div-s with semantic tags everywhere I could, but please point out if there was more semantic tags I could have used. This also shortened code a lot in the gallery section.