`connection.signIn()` discrepancies from `connect` docs - Githubissues

Greenruhm / connect

Greenruhm Connect is your white label, custom-branded connection to the music metaverse. It allows you to provide music NFT services inside your app with your branding.

MIT License

1 stars 0 forks source link

`connection.signIn()` discrepancies from `connect` docs #18

Closed oliver-day closed 2 years ago

oliver-day commented 2 years ago

1. Unable to sign-in with existing user

[ ] On connection.signIn with a valid user email , a "User Does Not Exist" error message is incorrectly being thrown in connect because there is no _id property in the response from the GET /api/profile/[profileId call.

STR:

Attempt to sign in with an existing email
Observe the returned error

2. All of `user` properties are not returned in GET `/api/profile/[profileId]` call

[x] The following User properties are NOT being returned in response for GET /api/profile/[profileId] call:
email
isni
ipi

STR:

Attempt to sign in with an existing email
Observe the returned response data for the GET /api/profile/[profileId] call:

3. User's `avatarImg` property is NOT consistent with `connect` docs

[ ] Update avatarImg to avatarImage in GraphQL scheme for User type to match connect docs

STR:

Find user in user collection in Fauna db by email
Observe the avatarImg property instead of avatarImage

4. `connection.signIn()` not found `email` error message does not match `connect` docs

[x] If the user does not exist, the connection.signIn() promise will reject with an "User Does Not Exist" error message instead of the "Account not found" error message described in the connect docs.

STR:

Attempt to sign in with an existing email
Observe the returned error message on /sign-in page

User in Fauna user collection:

fauna--user

GET /api/profile/[profileId] header:

GET /api/profile/[profileId] response:

connect/src/user/sign-in.js:

connect src features user sign-in

/sign-in page in connect:

connect--sign-in--page

ericelliott commented 2 years ago

Let's open a separate issue for each point.

Point 1 is good to address right now.
For point 2, isni and ipi are optional, and they're not currently set at user creation time, so I'm not sure you'll have a way to test a fix until we've implemented an update user function. That fix will need to wait until that work is done.
Point 3 - avatarImg vs avatarImage - I like avatarImage better, but there may be a lot of existing code that already depends on avatarImg. That might require a refactor.
Point 4 - easy enough to fix that. Go for it.