Greenruhm / connect

Greenruhm Connect is your white label, custom-branded connection to the music metaverse. It allows you to provide music NFT services inside your app with your branding.

MIT License

1 stars 0 forks source link

feat: add magic connect integration #43

Closed oliver-day closed 1 year ago

oliver-day commented 1 year ago

Description

Changes address issues: #30 , #40

Current progress: demo

Integrates error-cause package for handling errors from Magic
Add Magic Connect sign up and sign in flows

ericelliott commented 1 year ago

[ ] After web3Provider.listAccounts check to see if the user already exists in the database, if they do, we can get their email address from their existing account. If they don't, the user hasn't created an account yet and we can collect their email address now.
[ ] Make sure that Magic checks to see if the user is already signed in before you display the sign up form. Open a new bug report issue in this repo if they don't.
[ ] Handle the case where the user is signed in with our app, but not signed in with magic.
[ ] If the user is signed in with magic and not signed in with our app, automatically sign them in with our app.

ericelliott commented 1 year ago

Rule of thumb: Try to limit work in a PR to about 1 day's work. Aim for 1-3 days from commit to main branch merge. See DORA Metrics.

When PRs get big like this, and merging won't break things, we have 2 options: break the PR into several smaller PRs and merge a little at a time, or open tickets for changes and go ahead and merge as-is.

oliver-day commented 1 year ago

Rule of thumb: Try to limit work in a PR to about 1 day's work. Aim for 1-3 days from commit to main branch merge. See DORA Metrics.

When PRs get big like this, and merging won't break things, we have 2 options: break the PR into several smaller PRs and merge a little at a time, or open tickets for changes and go ahead and merge as-is.

Are you ok merging this as is? Both the Magic Auth and connect sign up and sign in flows work currently.

I am planning on working on the adding the correct error handling next.

After that I will then work on the changes for the Magic Connect flows that we discussed.

Each issue will be it's own PR moving forward.

ericelliott commented 1 year ago

Are you ok merging this as is? Both the Magic Auth and connect sign up and sign in flows work currently.

Yep! Make sure all the conversations have resolutions or new issues, then click "resolve conversation" on each, and then merge. 🎉