Greenruhm / connect

Greenruhm Connect is your white label, custom-branded connection to the music metaverse. It allows you to provide music NFT services inside your app with your branding.

MIT License

1 stars 0 forks source link

[WIP] fix: remove error codes from example components #53

Closed oliver-day closed 1 year ago

oliver-day commented 1 year ago

Description

Branched from fix/sdk-functions-error-handling
Addresses issue #48

NOTE: I have included an UserRejectedConsentToShareEmail error so that all errors generated in the existing sign in and sign up flows are created with error-causes. In an upcoming PR, we will move away from using magic.connect.requestUserInfo() and this error will no longer be necessary so it can be removed at that point in time.

TODO

Incorporate any changes to example components that need to be made based on changes to https://github.com/Greenruhm/connect/pull/52

ericelliott commented 1 year ago

Did you film a demo of this one or is it still in-progress?

oliver-day commented 1 year ago

Did you film a demo of this one or is it still in-progress?

@ericelliott no, not yet. I am working on resolving the issues I mentioned in this WIP PR for greenrumh-web: https://github.com/Greenruhm/greenruhm-web/pull/692

Once I am able to update the error message copy generated from greenruhm-web, I will record a demo.

oliver-day commented 1 year ago

Closing this PR as I have made an updated one with the fix/remove-error-codes-from-example-components-1 branch. This was done to avoid having to resolve merge conflicts as a result of later work that was done to this PR's base branch fix/sdk-functions-error-handling.