Greenruhm / connect

Greenruhm Connect is your white label, custom-branded connection to the music metaverse. It allows you to provide music NFT services inside your app with your branding.
MIT License
1 stars 0 forks source link

refactor: remove error codes from example components #60

Closed oliver-day closed 1 year ago

oliver-day commented 1 year ago

Description

NOTE: I have included an UserRejectedConsentToShareEmail error so that all errors generated in the existing sign in and sign up flows are created with error-causes. In an upcoming PR, we will move away from using magic.connect.requestUserInfo() and this error will no longer be necessary so it can be removed at that point in time ( https://github.com/Greenruhm/connect/issues/61 ).


Sign up / Sign in (through Magic Auth) Demo

https://vimeo.com/777156921/47ecc8c974

Sign up / Sign in (through Magic Connect) Demo

https://vimeo.com/777158257/428fb48d89

Demo of 500 error when connect.signUp hits greenruhm-web /api/create-account endpoint

https://vimeo.com/777160552/4f5cdf1163

Demo of 500 error when connect.signIn hits greenruhm-web /api/profile/${walletAddress} endpoint

https://vimeo.com/777162748/5c85c61eb7

oliver-day commented 1 year ago

@ericelliott After reviewing the changes in https://github.com/Greenruhm/connect/pull/59 and this PR, I would like to discuss how to approach documentation for the updated error handing with connect.

ericelliott commented 1 year ago

After reviewing the changes in https://github.com/Greenruhm/connect/pull/59 and this PR, I would like to discuss how to approach documentation for the updated error handing with connect.

Update the documentation in the /docs folder. I'll integrate it with the official docs on connect.greenruhm.com.

Do you have more specific questions?

oliver-day commented 1 year ago

Hey @ericelliott 👋 , I have added my first pass at the documentation for user sign up and sign in error handling. Let me know what you think and if you have any comments on my work related to the example components in this PR.

oliver-day commented 1 year ago

@ericelliott, thank you for the documentation and example component cleanup suggestions in https://github.com/Greenruhm/connect/pull/64. I have added those changes and validated that all variations of user sign up and sign in are working correctly and that the documentation matches the example flows.