Closed oliver-day closed 1 year ago
@ericelliott
After reviewing the changes in https://github.com/Greenruhm/connect/pull/59 and this PR, I would like to discuss how to approach documentation for the updated error handing with connect
.
After reviewing the changes in https://github.com/Greenruhm/connect/pull/59 and this PR, I would like to discuss how to approach documentation for the updated error handing with connect.
Update the documentation in the /docs
folder. I'll integrate it with the official docs on connect.greenruhm.com
.
Do you have more specific questions?
Hey @ericelliott 👋 , I have added my first pass at the documentation for user sign up and sign in error handling. Let me know what you think and if you have any comments on my work related to the example components in this PR.
@ericelliott, thank you for the documentation and example component cleanup suggestions in https://github.com/Greenruhm/connect/pull/64. I have added those changes and validated that all variations of user sign up and sign in are working correctly and that the documentation matches the example flows.
Description
fix/sdk-functions-error-handling-1
NOTE: I have included an
UserRejectedConsentToShareEmail
error so that all errors generated in the existing sign in and sign up flows are created witherror-causes
. In an upcoming PR, we will move away from usingmagic.connect.requestUserInfo()
and this error will no longer be necessary so it can be removed at that point in time ( https://github.com/Greenruhm/connect/issues/61 ).Sign up / Sign in (through Magic Auth) Demo
https://vimeo.com/777156921/47ecc8c974
Sign up / Sign in (through Magic Connect) Demo
https://vimeo.com/777158257/428fb48d89
Demo of 500 error when
connect.signUp
hits greenruhm-web/api/create-account
endpointhttps://vimeo.com/777160552/4f5cdf1163
Demo of 500 error when
connect.signIn
hits greenruhm-web/api/profile/${walletAddress}
endpointhttps://vimeo.com/777162748/5c85c61eb7