Greenruhm / connect

Greenruhm Connect is your white label, custom-branded connection to the music metaverse. It allows you to provide music NFT services inside your app with your branding.
MIT License
1 stars 0 forks source link

Change `signUpErrors.InvalidUserName` to `signUpErrors.InvalidUsername` #63

Closed oliver-day closed 1 year ago

oliver-day commented 1 year ago

Description

While creating the named signUpErrors error causes, I got a little too tab happy with GitHub Copilot and did not notice that I created the named InvalidUserName error cause where the "N" in username is capitalized. This named error cause does not follow the convention of other named error causes involving the username value like UsernameIsUnavailable or UsernameIsRequired, where the "n" in username is lowercase.

Update all references of signUpErrors.InvalidUserName to signUpErrors.InvalidUsername for the following:

This update will need to be performed in connect first, then we'll need to have a new public release of connect in order for this named error cause to be properly referenced for the updates in greenruhm-web.

ericelliott commented 1 year ago

Good catch. I missed that in the review!