Greenruhm / connect

Greenruhm Connect is your white label, custom-branded connection to the music metaverse. It allows you to provide music NFT services inside your app with your branding.
MIT License
1 stars 0 forks source link

Build process is not working as expected #75

Closed brunomoutinho closed 1 year ago

brunomoutinho commented 1 year ago

With current process (using swc to build components' files to folder components), when importing a component like the SignUp component, there are imports for files that were not built or moved into the new folder, like the src/index.js file, which contains the connect module.

One option to solve this would be to build all files and put them in the root folder (which would keep the current /components folder and add all other folders and files under src in the root directory). This keeps all the relative placement of all files the same.

Another possible option would be to build all files into a /build folder. This way, whoever wants to import components from @greenruhm/connect would do so from @greenruhm/connect/build/components/component-name.

Finally, we could investigate and try to bundle each components' dependencies with the component itself during build. I have not been able to discover how to do that yet, but I can move in this direction.

Do you have any preferences, @ericelliott ?

brunomoutinho commented 1 year ago

Also, when making some modifications inside node_modules in greenruhm-web repo, I was getting an unexpected error after going through the Magic process. I am still investigating why this is happening, as I am unable to trace the problem.

image
ericelliott commented 1 year ago

Maybe we can use a different name in place of build, like ui? It's my understanding, we only need this build process for the react components, and not the rest of the SDK? So users will import from @greenruhm/connect/ui/components?

brunomoutinho commented 1 year ago

Sure :) I'll add this modification and open a PR that we can review to see if it is what we expect it to be!