search

Greenstand / treetracker-earnings-api

GNU General Public License v3.0
5 stars 8 forks source link

feat(earnings model): initialise funder field based on org_name instead of name field #22

Closed Mloweedgar closed 2 years ago

dadiorchen commented 2 years ago

@Mloweedgar to solve these failing tests. Please mock the API for the upstream API/service. like the stakeholder.

This is an example: https://github.com/Greenstand/treetracker-messaging-api/blob/27277890d48369aaa6ca439c54dd1f7a1523fb76/api-tests/message-api.spec.js#L9-L29

dadiorchen commented 2 years ago

So in this way, we don't rely on external factors to build our API

dadiorchen commented 2 years ago

Is there any trouble mocking the api? @Mloweedgar

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.9.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

dadiorchen commented 2 years ago

@Mloweedgar I will merge this first, when you finished the mock please raise a PR again

Mloweedgar commented 2 years ago

Okay @dadiorchen, I will do that, currently I am working to make tests run in my locally computer after that I will mock the api