search

Greenstand / treetracker-earnings-api

GNU General Public License v3.0
5 stars 8 forks source link

Missing column in earnings table #66

Open philnorc opened 2 years ago

philnorc commented 2 years ago

According to testCases.md, https://github.com/Greenstand/treetracker-earnings-api/blob/main/docs/test/testCases.md, the earnings table should have a column "Sub organization name" Neither the test panel nor the dev panel have that column. https://test-admin.treetracker.org/earnings https://dev-admin.treetracker.org/earnings

dadiorchen commented 2 years ago

The same as Greenstand/treetracker-admin-client#612

philnorc commented 2 years ago

No. 66 & 67 are not the same. Greenstand/treetracker-admin-client#612 concerns the column "Count of Captures" in the payments table. Greenstand/treetracker-earnings-api#66 concerns the column "Sub organization" in the earnings table.

dadiorchen commented 2 years ago

@philnorc yes, you are right!

philnorc commented 2 years ago

The missing column for "Organization" is particularly a problem because we provide a filter option for Organization. It is hard to use a filter for values you cannot see.

And where do the values in the Organization menu come from? They do not include the only organizations I see in the data: Child One, Child Two, Greenstand, and null.

dadiorchen commented 2 years ago

Yes, I agree, I added this feature to milestone 2, because adding this feature cause change on both back end and front end, it's risky to add it at this testing round stage.

The org menu is from the infrastructure of the admin panel, there are some problems with the authentication workflow, so you find it's incorrect, we will figure it out in the future, and also it's not the problem of earning tool (it's about stakeholder system)