search

Greenstand / treetracker-earnings-api

GNU General Public License v3.0
5 stars 8 forks source link

Can upload bad file as payment #75

Closed dadiorchen closed 2 years ago

dadiorchen commented 2 years ago

up-badFields.csv up-badValues.csv

philnorc commented 2 years ago

In tests just now (April 6, 16:30 Chicago time) the tool properly rejected upload files with missing fields or empty values. It also rejected files with good data values, but without field names in line 1.

dadiorchen commented 2 years ago

@philnorc you mean without the header? I think we can define the file to must have the header as the first line, and it's also a good practice when people open the file with excel, if we don't have the header, it's hard to tell which column is which?

philnorc commented 2 years ago

Yes, right, the line 1 of the file must be "earnings_id","worker_id","phone","currency","amount","captures_count","payment_confirmation_id","payment_method","paid_at"