search

Greenstand / treetracker-query-api

To fetch Greenstand map data for client's like web map, wallet app, and so on.
GNU General Public License v3.0
14 stars 59 forks source link

fix: species v2 #359

Closed aayushgauba closed 1 year ago

aayushgauba commented 1 year ago

Species V2 doesnot use herbarium.species and follows legacy version. This fixes that

dadiorchen commented 1 year ago

@aayushgauba thank you for your contribution, but there are some problem with this PR, I think majorly it is a problem of communication, in the v2 version, we can not use tables in herbarium because we will delay that part and got a bigger plan on herbarium system, so in a very long future there wouldn't be any data in herbarium, actually, we will use the species table in treetracker so can you change this to use that table? I think to avoid this in the future, we can use the project board and issue ticket to improve the communication, like, creating a issue for this PR first, and assigning it to the developer and once you start to work on it, you can make it in status=In Progress, in this way, I think it is more likely we can do a early discussion on this, and find out the misunderstanding. Thank you for help us pushing this forward!

aayushgauba commented 1 year ago

@dadiorchen I assume that the table is treetracker.species right?

dadiorchen commented 1 year ago

yes

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.70.5 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: