407 Add 404 errors for some endpoints - Githubissues

Greenstand / treetracker-wallet-api

GNU Affero General Public License v3.0

18 stars 53 forks source link

407 Add 404 errors for some endpoints #408

Closed pranavkparti closed 1 year ago

pranavkparti commented 1 year ago

Description

The endpoints mentioned in the issue below now show appropriate error codes.

Issue(s) addressed

Resolves #407

What kind of change(s) does this PR introduce?

[ ] Enhancement
[X] Bug fix
[ ] Refactor

Please check if the PR fulfils these requirements

[X] The commit message follows our guidelines
[X] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Issue

What is the current behavior? 403 code is being used where 404 should be used.

What is the new behavior? The endpoints return 404 is the entity matching the query parameter is not found or is associated with a different wallet.

Breaking change

Does this PR introduce a breaking change? No.

Other useful information

None.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.27.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: