Open dadiorchen opened 5 months ago
Thank Dadio, it looks good. jwt is an open standard so that ticks the main box.
A question regarding the 7 day expire case. Is the wallet at that point created already and the tokens transfered? If so how can the user retrieve that data?
The wallet is not created till the new user receive and click the link to register, so nothing happen before that, that’s a intention of transfer stored in the action token, it will be executed when new user coming in and login into wallet app, so this solution has possibility that the promised token can not be transfer because the change by the owner side, so solve this problem would bring huge complex and workload to system, it don’t worth the price at this stage, we can add it in the future.
ok. So we would need to block those tokens to be in transfer, right? So thats "pending" state or?
In this first version we don’t do that, because it bring much more work into the project, we simply give the responsibility to the owner to take care it, when it release and we get feedback on this feature, we can start to consider an complete mechanism on this.
As proposed in this picture below, we want to use wallet API to issue
Action Token
and send token to an account that will be registered in the future. So in this issue, we will implement a integration test that covers:action token
is expired, the request is denied.In details, the integration tests are:
Action Token
, simulates a new user coming in and create new wallet account, then apply the token that specified in theaction token
, wallet API verify theaction token
, if okay, then do the transfer, if not, deny it.Reference reading: