search

Greenstand / treetracker-wallet-app

The Greenstand Wallet App
https://wallet.treetracker.org
14 stars 43 forks source link

Feature loading UI #232

Open Lorenabelo opened 1 month ago

Lorenabelo commented 1 month ago

Description

In this PR only the component called loading has been created, so that it can be implemented in the login and sign up screens.

Type of change

resolves #220

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Checklist:

[x] I have performed a self-review of my own code [ ] I have commented my code, particularly in hard-to-understand areas [ ] I have made corresponding changes to the documentation [ ] My changes generate no new warnings [ ] I have added tests that prove my fix is effective or that my feature works [ ] New and existing unit tests pass locally with my changes [ ] Any dependent changes have been merged and published in downstream modules

pierrelstan commented 1 month ago

@Lorenabelo thanks for you contribution! If the issue is about creating a single component, I suggest we create component test with Cypress to cover it, @pierrelstan what do you think?

I agree @dadiorchen, it is a good idea to test it.

Davidezrajay commented 2 weeks ago

@pierrelstan can you guide @Lorenabelo though what needs to happen to merge this request?

pierrelstan commented 2 weeks ago

@Davidezrajay Will do! It just needs an update with the latest changes from the main branch.