Greenstand / treetracker-wallet-app

The Greenstand Wallet App
https://wallet.treetracker.org
14 stars 43 forks source link

feat: nestjs user api and e2e tests (#256) #257

Open dorukucak opened 3 weeks ago

dorukucak commented 3 weeks ago

Fixed: #256

Description

Created nestjs server and implemented a user API that expose an /register endpoint.

Resolves: # (#256)


Changes Made


Type of Change


Screenshots

Before After
"screenshot before" "screenshot after"

How Has This Been Tested?


Checklist:


Additional Comments

(Optional) Add any additional comments or notes for reviewers here.

dadiorchen commented 2 weeks ago

@dorukucak you finish it? Can you e2e test pass? Please add your command to run your e2e in the readme.md, then we can merge your code.

dorukucak commented 2 weeks ago

Working on implementing keycloak. Couldn't find a keycloak endpoint to register user. Do we have that?

dadiorchen commented 2 weeks ago

@pierrelstan we need your help here

pierrelstan commented 2 weeks ago

@dorukucak I think these links could help find the register endpoint.:

and the implementation of the register API endpoint is in the web (nextjs) under the path src/app/api/auth/signup.

If you have any questions, feel free to let me know.

dorukucak commented 2 weeks ago

Okay so, I had to create a Keycloak service account and give it manage-user privilages. Now we can succesfully create users using the /register endpoint. However, we need to handle API secrets before we can run tests on github workflow etc.

pierrelstan commented 1 week ago

@dorukucak Could you kindly resolve the merge conflicts?

dorukucak commented 1 week ago

resolved conflicts in yarn.lock

dorukucak commented 1 day ago

This is ready