Greenstand / treetracker-wallet-app

The Greenstand Wallet App
https://wallet.treetracker.org
14 stars 43 forks source link

Map module can not update the url correctly. #99

Closed dadiorchen closed 3 years ago

dadiorchen commented 3 years ago

https://www.loom.com/share/6eeb09bfb02341f6bedd28486f8716c2

dadiorchen commented 3 years ago

To fix the problem, we also need to consider making the module https://github.com/Greenstand/treetracker-web-map-client/blob/master/src/models/Map.js more flexible, the thing is, we do the URL update in the module, Map.js, it's inappropriate, because the map should be focused on map stuff, rather then the browser feature, in another way, the Map.js shouldn't know the concept of browser (the location object), we need to move this part of code out of the Map.js

dadiorchen commented 3 years ago

This requires some changes on the web map client repo, including changing the code that invokes the Map.js in the repo.