search

Greenstand / treetracker-web-map-api

The web map including impact panel views
http://dev.treetracker.org, http://test.treetracker.org
GNU Affero General Public License v3.0
27 stars 51 forks source link

Circular border of planter image needs to work with non-square images #114

Closed ZavenArra closed 5 years ago

ZavenArra commented 5 years ago

Many times planter images are not square. The styles for image tag with id 'planter_image' should be updated so the planter image does not ever display as an oval.

image image

vacuumdreams commented 5 years ago

taking a look at this one, as suggested by Liam. dealing with this on the client side is not the best practice imho, could implement a cropping service. CSS is too dumb to tell if something is circle or oval. doing it on client side js would be messy and slow. as i see the image is coming from digital ocean. is that uniform for all profile pictures? they don't have a cropping service as far as i see, unfortunately, which complicates things. the second comment on this thread looks like something we're looking for: https://www.digitalocean.com/community/questions/how-to-resize-images-on-spaces would need some pointers if we can add something to the infrastructure to do this, or client side hack is something you'd be looking for instead.

quorth0n commented 5 years ago

Fixed via #115