Closed dadiorchen closed 2 years ago
Some resource I found:
https://en.wikipedia.org/wiki/Gallery_of_sovereign_state_flags
Hi @dadiorchen, can I work on this?
@Koda-Pig yes, sure, I will assign it to you.
Also, I suggest using the Cypress unit tool for a showcase of all these flag icons, but it is not mandatory.
Thanks @dadiorchen. Sorry if this is a basic question, but after getting this running, any changes I make to /node_modules/treetracer-web-map-core/src/Map.js has no effect on the front end. For example; as a test to see if I was editing the correct file, I replaced 'K' with 'P' here:
static formatClusterText(count) { if (count > 1000) { return ``${Math.floor(count / 1000)}PK``; } return count + 1000; }
I have checked if there is a .next file in the root folder that was caching, but there was none. I have also tried the command:
npm cache clean --force
Which didn't work. I also tried terminating the batch job and restarting it, still no difference.
I think I am missing something here. Any help would be greatly appreciated.
@Koda-Pig are you in our slack channel? if not you can leave your email and I will invite you, that's a better place for coordination and discussion.
So you are run into the import css
problem? right? basically, remove .next works for me.
formatClusterText function I'm not sure you can immediately find the changing on the map viewer even you are doing things right, because it just gets invoked when you hover your mouse on the cluster icon, the cluster icon on the map by default is not displayed by Map.js, they are map-tile-layer provided by our another service (they are png picture)
I'm not in the slack channel, please add me with josh[.]koter@gmail.com.
I ran into the import css problem, but I used the workaround you mentioned here to fix it: https://github.com/Greenstand/treetracker-web-map-core/issues/23
If that's the case, how do I make changes to the actual map component?
If you mean how to change the Map.js, you can fork the treetracker-web-map-core repo and raise PR against this repo, once your PR is accepted, we will raise the version of the core, then all those repos using this core can upgrade the core.
Please see my pull request here: https://github.com/Greenstand/treetracker-web-map-client/pull/348
I guess @Koda-Pig is unavailable on this now, so if anyone can take over, it would be great, and also, his work is a good reference: https://github.com/Greenstand/treetracker-web-map-client/pull/348
:tada: This issue has been resolved in version 1.15.0-beta.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
We are going to show the country with the flag icon, so we need a set of icons for this purpose.
We don't have are a standard way to identify the country, so for a temporarily solution, just use the name of country as the key, below is the list of country name:
(so we can load the flag icon in the probjet like this: )
Please put all these flag icons into the component tool to display them all.
Some hints: