Greenstand / treetracker-web-map-client

The front end of the treetracker web map app.
http://map.treetracker.org
GNU Affero General Public License v3.0
64 stars 182 forks source link

Adapt tree slider to mobile device. #346

Closed dadiorchen closed 2 years ago

dadiorchen commented 2 years ago
Screen Shot 2021-12-04 at 5 32 24 PM

Please add a new test in component unit test file, and paste a screenshot when creating PR.


Some hints for building components:

wendyyuchensun commented 2 years ago

Hi, just curious does this need to be a new component? It seems like it can be achieved by just adjusting CSS like https://github.com/wendyyuchensun/treetracker-web-map-client/commit/2c022668419d4a5fd97eb94a109fcb66f791b0fe .

Screenshot ezgif-2-9d94ce75cb95

dadiorchen commented 2 years ago

awsome!!! yes, our goal is to reuse the component as much as possible, and your solution looks pretty neat! Can you raise a PR for us? BTW, the image size is the same as the Figma design? I mean the mobile version.

wendyyuchensun commented 2 years ago

Yes, mobile image is 152px * 152px . https://www.figma.com/file/XdYFdjlsHvxehlrkPVYq0l/Greenstand-Webmap?node-id=4355%3A15745

Screen Shot 2021-12-07 at 2 09 13 PM

,

wendyyuchensun commented 2 years ago

Here is the PR: https://github.com/Greenstand/treetracker-web-map-client/pull/352 Let me know if any issue with it, thanks. :)

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 1.15.0-beta.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: