search

GreepTheSheep / openplanet-MXRandom

An Openplanet plugin that takes a random map from MX / TMX and play it
https://openplanet.dev/plugin/mxrandom
GNU General Public License v3.0
19 stars 28 forks source link

Syntax error in RMS.as #112

Closed roncli closed 11 months ago

roncli commented 11 months ago

Describe the bug Commit 901afa1bfe416971d953851524d2dcc74f82e7e3 introduced a syntax error that breaks RMS.as. An #endif is present, but no matching #if exists.

To Reproduce Steps to reproduce the behavior:

  1. Start Trackmania
  2. Once all is loaded, check the OpenPlanet logs
  3. Error shows there is an unmatched #endif in line 68 (it does not say the file, I had to look!)

Expected behavior Syntax error should be fixed, and no error should be present.

Screenshots n/a

Openplanet (please complete the following information): Issue is not related to Openplanet. Version: 1.26.4 Game: TM2020

Additional context n/a

GreepTheSheep commented 11 months ago

Found it: https://github.com/GreepTheSheep/openplanet-MXRandom/blob/41c041ea6943117c7719639c7861d454d7e461a9/src/Utils/RMC/RMS.as#L68C1-L68C7 I don't know why I left a #endif here, will take a look later

EdVraz commented 11 months ago

I seem to have deleted the #if TMNEXT but accidentally kept the #endif for it here. I didn't notice because when I tested the changes everything worked fine, which it still does from what I can tell? I can play RMC and RMS without issues even though the syntax error is present.