search

GreepTheSheep / openplanet-MXRandom

An Openplanet plugin that takes a random map from MX / TMX and play it
https://openplanet.dev/plugin/mxrandom
GNU General Public License v3.0
20 stars 30 forks source link

Fix issues with TMExchange api being slow on RMC #74

Closed Mistercoolertyper closed 1 year ago

Mistercoolertyper commented 1 year ago

I did some testing and found out, that the TMExchange API sometimes responds very slowly or errors outright when there's too many arguments it seems like. I have removed the "mtype=TM_Race" parameter and made it check for the map type in the plugin code itself so it wouldn't take so long to get the next random map or error when trying to get a map.

GreepTheSheep commented 1 year ago

This parameter is important in RMC because it can load Royal / FlagRush / Puzzle maps that aren't supported by the game. Also I already found a way to change parameters with "lengthop" and "length" parameters by using plugin configs (see #68)

Mistercoolertyper commented 1 year ago

i know, that the parameter is important, that's why i added a check to check, if the map type is the right one in the PreloadRandomMap function. if you can get around this already by changing the lengthop and length parameters though, that's good to know. Would be nice, if you can add some kind of info somewhere in the plugin, so people know how to fix long tmx loading times. Seen a lot of streamers complaining about it recently so there should probably be some kind of info/warning telling people to turn down those settings, if the maps take too long to load or something like that.

Anyways, thanks for letting me know, that there's already a way to fix/prevent this issue.

Mistercoolertyper commented 1 year ago

Also one more question, where do you set the lengthop and length settings, since i cant find it in the plugin settings rn?

GreepTheSheep commented 1 year ago

Also one more question, where do you set the lengthop and length settings, since i cant find it in the plugin settings rn?

Just to make you sure: Plugin Config ≠ Plugin Settings. Plugin Config is a set of configs defined by me that are loaded when plugin starts, in this example the parameters were hardcoded before, now they are loaded through plugin configs

https://github.com/GreepTheSheep/openplanet-MXRandom/blob/main/src/Utils/MX/Methods/LoadRandomMap.as#L95-L97

Mistercoolertyper commented 1 year ago

ah ok, thanks for clarifying.