GreepTheSheep / openplanet-MXRandom

An Openplanet plugin that takes a random map from MX / TMX and play it
https://openplanet.dev/plugin/mxrandom
GNU General Public License v3.0
20 stars 29 forks source link

RMT kept "switching" to the same map repeatedly #88

Closed Wain4 closed 11 months ago

Wain4 commented 1 year ago

An AT was beaten, then RMT "switched maps", but the next map was the same as the previous, and the room timer started at 0:02. After the room timer expired, it switched to the same map again. In the voting menu, the server's map list contained the stuck map and the lobby map.

VOD: https://www.twitch.tv/videos/1847061503?t=2h46m8s

Lars speculated that this might happen when RMT randomly picks the same map twice in a row.

Wain4 commented 1 year ago

VOD with log: https://www.twitch.tv/videos/1852933721?t=1h47m21s

Wain4 commented 1 year ago

In the log from 2 weeks ago, the plugin found a next map. The map looked normal, but it wasn't uploaded to nadeo services. Any chance that can be an issue? In today's occurrence, the plugin found a map from xk.io, the map is unlisted on TMX and has "WIP" in the name. I can't access the map at all. Log from today: image

GreepTheSheep commented 1 year ago

@Wain4 this is not the subject, can you make another issue about this ?

Wain4 commented 1 year ago

XertroV made one already: #95 Not sure how this is not the subject though, both cases look the same (room keeps switching to the same map).

XertroV commented 1 year ago

In today's occurrence, the plugin found a map from xk.io, the map is unlisted on TMX and has "WIP" in the name. I can't access the map at all.

This can happen when someone uploads a map and later removes it. Basically my server cached it but tmx doesn't offer the download link anymore. One solution is to use the CGF mirror which usually downloads maps once they're available. Another solution is loading the map from nadeo if it's uploaded -- since the UID is in the tmx/random response, the map can be checked using core game APIs and then optionally loaded via the URL parameter of the game's map info response.

So we should be able to solve this case with a combination of those measures.

Additionally, when I implement update scraping from TMX the API should no longer return those maps.

Wain4 commented 1 year ago

Additionally, when I implement update scraping from TMX the API should no longer return those maps.

Is this done? GranaDy had this issue today.

I wasn't there to tell him to show the log, and I'm not even sure whether he's using xk or tmx, but what I can see in the VOD is: The next map is found, it's called "Lost Island", all 3 public maps with that name on TMX look normal, and the vote text says "JumpToMapIdent ????" (question marks instead of the map name). https://www.twitch.tv/videos/1871547786?t=2h10m16s

XertroV commented 1 year ago

Is this done? GranaDy had this issue today.

Yes, it's done now. I also check map URLs before redirecting in this order of priority:

  1. TMX
  2. Nadeo (since it's uploaded to nadeo services)
  3. CGF mirror