search

GreepTheSheep / openplanet-MXRandom

An Openplanet plugin that takes a random map from MX / TMX and play it
https://openplanet.dev/plugin/mxrandom
GNU General Public License v3.0
20 stars 29 forks source link

add buttons for setting different API endpoints #92

Closed XertroV closed 1 year ago

XertroV commented 1 year ago

image image

XertroV commented 1 year ago

Can you make a change to the variable (see comment)

I'm not sure which comment you're referring to, or which variable. The only comment I saw you make was about Dan's API and waiting to merge. If you were talking about that, it's not obvious what change you're after (just uncomment again?).

edit: did you add a comment that you didn't save in the review thing? i've done that before and it gets lost

GreepTheSheep commented 1 year ago

yeah this comment, forgot to sent it x)

XertroV commented 1 year ago

yeah this comment, forgot to sent it x)

I still don't know what change you want. can you please just tell me?

Also, mb remove this from the 2.3.5 milestone? There is an unreleased fix that people are waiting for before doing more RMT, and it doesn't make sense to hold up releasing a fix to a game breaking bug because of a button to set a text value for an alt API.

dwhitacre commented 1 year ago

My api is technically up and running and ready to go, but I am not sure I love the idea of making it a button in the menu. Although, I was happy to spend the time to setup and host a separate api cache for myself, friends, and associates; I dont really have the time to maintain it for a larger user base. I am totally fine for people to stumble upon my api cache via informal means or sharing and to use it regularly, but making it an option in the UI makes it too easily available to become something that people just use as a replacement for using the tmx api directly; and then something Id feel a larger responsibility towards maintaining.

Ultimately, I'd rather people host their own copy of https://github.com/dwhitacre/mx-api-cache if they want to have their own personal cache of tmx random maps preloaded, rather than me try to host a single instance for all users. Furthermore, ive licensed it as MIT so if people wanted to implement the same code or ideas straight into their own services, id happily support and help as well.