Greg-Tan / pe

0 stars 0 forks source link

there is no checker for non sensible phone numbers #3

Open Greg-Tan opened 2 months ago

Greg-Tan commented 2 months ago

your ug did not specify that the app was to be used only in the singaporean context where phone numbers are 8 digits long and by right should start with 8 or 9. and i was able to add non sensible phone numbers like "11111111"

nus-se-script commented 2 months ago

Team's Response

We never explicitly stated that it's only in the Singaporean context, we only stated the restriction of 8 digits.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Even if the app was not to be used in the singaporean context, then there should not be a restriction of just 8 digits as other country phone numbers could be longer than 8 digits. What I am trying to say is that there are insufficient checkers in place for an appropriate phone number especially when the context of the app in terms of region is not defined.