Greg-Tan / pe

0 stars 0 forks source link

add command phone number does not allow for foreign phone numbers #4

Open Greg-Tan opened 6 months ago

Greg-Tan commented 6 months ago

ug did not specify that the app was to be used in a singaporean context where phone numbers are strictly 8 characters. If I had a foreign phone number, I would not be able to add the phone number to the address book as foreign phone numbers could have more than 8 characters

nus-pe-bot commented 6 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Phone number only work with SG numbers

Phone number feature does not allow people to key in phone numbers that are non-SG numbers like 11 digit numbers in China. This is troublesome as it is stated in the UG that it navigate and utilise the FnBuddy part-time employee contact management application with ease but it cause troubles if phone number of the person not local cannot be recorded.

For example, it is common to outsource jobs or do collaborations with people/company outside SG(artists, for example) and by not having the ability to key in their contacts ready in the book, it can hinder the effectiveness of the app. Screenshot 2024-04-19 at 4.46.49 PM.png


[original: nus-cs2103-AY2324S2/pe-interim#1049] [original labels: severity.Medium type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.DocumentationBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Medium`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]