search

GregBowyer / cld2-cffi

Python bindings to the Compact Language Detector
Apache License 2.0
32 stars 10 forks source link

Fix Python 3 support #4

Closed pquentin closed 8 years ago

GregBowyer commented 8 years ago

@pquentin These changes are all very reasonable and quite simple. If I merge them in this week would it help you to do a version bump for pypi?

GregBowyer commented 8 years ago

@pquentin Thanks for the fixes I have pushed a 0.1.2 for you that should be good for python3

pquentin commented 8 years ago

@GregBowyer Thanks! And yes, the version bump helps a lot!

I think things would be cleaner if detect() required bytes instead of converting automatically from str to bytes in Python 3, but that would have required more work to keep the tests up to date. But if we agree on this, I can send a pull request.