search

GregHilston / Simple-Slack-Bot

Simple Python library for creating Slack bots.
https://greghilston.github.io/Simple-Slack-Bot/
MIT License
24 stars 9 forks source link

Development #20

Closed ramast closed 7 years ago

ramast commented 7 years ago

Change the way callback functions respond to user. breaks backward compatibility, Please don't merge to master

GregHilston commented 7 years ago

@ramast What does "Please don't" mean? haha

ramast commented 7 years ago

Corrected it :)

GregHilston commented 7 years ago

Checked over the changes and they all look great! I'm going to do a local merge over lunch and test everything out before accepting the pull request. I'm thinking we call this effort "Milestone 2.0

ramast commented 7 years ago

Absolutely, Once we finish all the improvements we discussed, test it, maybe add test cases? we should release it to master under the name Milestone 2 (or any other name you like).

I'll create some issues with the things I think can be improved then we discuss each one on it's own thread

GregHilston commented 7 years ago

This looks excellent! I like the structure of the Request class. It adds alot to the library! Merging now